It’s the estate that makes the income though, not the family. In the UK most of that estate is owned by the position of the monarch itself rather than by the monarch; a perk of the job, not private property. In other words it’d probably still make just as much money in a republic, arguably more since we could let visitors in to see the buildings